Fix deleteWordRight behavior with multiple whitespace#306105
Open
robot-mazeee wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix deleteWordRight behavior with multiple whitespace#306105robot-mazeee wants to merge 1 commit intomicrosoft:mainfrom
robot-mazeee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Previously, deleteWordRight behaved inconsistently when multiple whitespace characters appeared before the next word. In such cases, only the whitespace was removed, while a single whitespace correctly removed both the whitespace and the following word. Fix: Update the whitespace heuristic to treat consecutive whitespace as a single region and continue deletion through the next word when using WordEnd navigation. Behavior is now consistent across cases: - Multiple spaces before a word are removed together with the word - Punctuation is not consumed (e.g. numbers with decimals) - Word boundaries such as underscore-separated identifiers are handled correctly This preserves existing behavior for non-word tokens while fixing the whitespace edge case. Fixes microsoft#259145
Author
|
@microsoft-github-policy-service agree company="Instituto Superior Técnico" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, deleteWordRight behaved inconsistently when multiple whitespace characters appeared before the next word. In such cases, only the whitespace was removed, while a single whitespace correctly removed both the whitespace and the following word.
Fix: Update the whitespace heuristic to treat consecutive whitespace as a single region and continue deletion through the next word when using WordEnd navigation.
Behavior is now consistent across cases:
This preserves existing behavior for non-word tokens while fixing the whitespace edge case.
Fixes #259145