fix: dispose createModelReference ref on stale element in disassemblyView

[Copilot]

In renderElementInner, the model reference acquired via createModelReference was leaked when the async race guard detected a stale element — the ref was never disposed before the early return.

Changes

• disassemblyView.ts: Call ref.dispose() before returning when templateData.currentElement.element !== element, preventing the model reference leak on the stale-element code path.

// Before
const ref = await this.textModelService.createModelReference(sourceURI);
if (templateData.currentElement.element !== element) {
    return; // ← ref leaked
}

// After
const ref = await this.textModelService.createModelReference(sourceURI);
if (templateData.currentElement.element !== element) {
    ref.dispose(); // dispose before bailing out
    return;
}

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

Fixes a resource leak in the Debug Disassembly View’s instruction renderer by ensuring ITextModelService.createModelReference() results are disposed when an async render detects the element has become stale.

Changes:

• Dispose the acquired model reference before early-returning on the stale-element race guard in InstructionRenderer.renderElementInner.

[Copilot]

The new stale-element guard disposes the ref when the template is reused, but the same async race can still leak when the row/template gets disposed (e.g. list/view disposed) while awaiting createModelReference: currentElement.element remains element, so the guard won’t trigger and the ref can be pushed after disposeElement has already run. Consider clearing templateData.currentElement.element in disposeElement (or tracking a render/dispose token) so the post-await check reliably detects disposed templates and disposes the ref before returning/continuing.

Suggested change

	const ref = await this.textModelService.createModelReference(sourceURI);
	const ref = await this.textModelService.createModelReference(sourceURI);
	// If the template has been disposed while awaiting the model, its DOM node will be detached.
	// In that case, dispose the ref and stop to avoid leaking the model or touching stale DOM.
	if (!templateData.sourcecode.isConnected) {
	ref.dispose();
	return;
	}