fix: adjust GitHub check run char limit considering the MD terraform text wrapper#2615
Open
sav-valerio wants to merge 2 commits intodiggerhq:developfrom
Open
fix: adjust GitHub check run char limit considering the MD terraform text wrapper#2615sav-valerio wants to merge 2 commits intodiggerhq:developfrom
sav-valerio wants to merge 2 commits intodiggerhq:developfrom
Conversation
… the tf text wrapper Fixes a side case in diggerhq#2550 diggerhq#2542
sav-valerio
changed the title
sav-valerio
changed the title
s1ntaxe770r
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing truncation logic in
UpdateCheckRunForJobtruncatesTerraformOutputto 65,535 characters, but then wraps it in a markdown code block ("terraform\n ...\n") adding 17 characters.This causes the final text sent to GitHub's Check Run API to be 65,552 characters, exceeding the 65,535 limit and resulting in a 422 error.
The fix subtracts the wrapper length from the truncation limit so the final text stays within bounds.
Test is also updated to assert on the final wrapped text rather than just the raw output.
Follows up on #2550
Relates to #2542
🧠 Ai UsageDetails (if applicable):
IMPORTANT: Please disclose any usage of ai tooling while making this change. If you did not use any AI write "NA" below