Fix model header normalization for custom providers#1577
Open
corazzione wants to merge 1 commit intobytedance:mainfrom
Open
Fix model header normalization for custom providers#1577corazzione wants to merge 1 commit intobytedance:mainfrom
corazzione wants to merge 1 commit intobytedance:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1531
Summary
This PR makes model construction more tolerant of custom provider headers that are accidentally declared at the model root in
config.yaml.Problem
Some custom-provider configs include HTTP headers such as
User-Agent. When those header entries leak into the model config root instead of being nested underdefault_headers, DeerFlow forwards them as direct constructor kwargs and provider SDKs fail with errors like:AsyncCompletions.create() got an unexpected keyword argument 'User-Agent'Fix
default_headersbefore instantiating the model classdefault_headersflowUser-Agentnormalization for a custom provider configValidation
./.venv/Scripts/python.exe -m pytest tests/test_model_factory.py -q./.venv/Scripts/python.exe -m ruff check packages/harness/deerflow/models/factory.py tests/test_model_factory.py